Codecov Report

Merging #734 into master will increase coverage by 0.28%.
The diff coverage is 74.5%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   66.18%   66.46%   +0.28%     
==========================================
  Files          23       22       -1     
  Lines        1307     1309       +2     
==========================================
+ Hits          865      870       +5     
+ Misses        442      439       -3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452c8fa...53af566. Read the comment docs.

@jshjohnson can we rename sortFn to sortProvider? My breaking PR is to introduce searchProvider and make it easy to build autocomplete on top of Choices

And also removing completely all sort related settings - I mean, if sortProvider is set, then it makes all the rest of decisions.

I would like to do similar approach to searchProvider - it will allow us to decouple fuse.js and bunch of settings we are having around it now.

That's also can be done in a way of deprecation - I mean, undocument old settings now, but still support it until next major.

BTW, my searchProvider will be supporting promises (similar to setChoices approach), not sure if that makes sense for sorting, but...

BTW, my searchProvider will be supporting promises (similar to setChoices approach), not sure if that makes sense for sorting, but...

Hmm, hard to say without seeing your implementation. Do you mind if I keep this as is for the time being and if we think we need to update it after your search PR, we can?